fix: store new_contributor parameter in __init__#407
Merged
Conversation
Remove the unconditional reassignment of new_contributor = False that caused the constructor parameter to be silently ignored. Closes #406 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
jmeridth
approved these changes
Feb 24, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes ContributorStats.__init__ so the new_contributor constructor argument is no longer unconditionally overwritten, allowing callers to initialize the instance with the intended value (per #406).
Changes:
- Removed the unconditional
new_contributor = Falsereassignment insideContributorStats.__init__.
- Move new_contributor param to end of __init__ with default=False - Remove redundant False args from all call sites - Add test_init_new_contributor_true regression test Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the unconditional
new_contributor = Falsereassignment inContributorStats.__init__that caused the constructor parameter to be silently ignored.Problem
The
new_contributorparameter passed toContributorStats.__init__was immediately overwritten bynew_contributor = Falseon line 51, making the parameter misleading and preventing callers from initializing instances with a known value.Fix
Remove the reassignment so
self.new_contributorstores the passed-in value (which defaults toFalse).Closes #406